fix: add offline support for anonymous targeted user via braze notifications #8603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
themooneer
force-pushed
the
fix/LIVE-15007
branch
5 times, most recently
from
36575be to
8ddefc1
Compare
KVNLS
requested changes
Dec 4, 2024
...ledger-live-desktop/src/newArch/features/DynamicContent/components/LogContentCardWrapper.tsx
Outdated
Show resolved
Hide resolved
...ledger-live-desktop/src/newArch/features/DynamicContent/components/LogContentCardWrapper.tsx
Show resolved
Hide resolved
themooneer
force-pushed
the
fix/LIVE-15007
branch
2 times, most recently
from
9d1a7eb to
91ee3dd
Compare
themooneer
force-pushed
the
fix/LIVE-15007
branch
2 times, most recently
from
98102af to
52f3b74
Compare
|
I've tested it but now it seems like with analytics on the notif remains active even if the card has the field viewed sets to true Screen.Recording.2024-12-06.at.10.30.58.mov |
themooneer
force-pushed
the
fix/LIVE-15007
branch
2 times, most recently
from
21b1ea0 to
c1a9ed3
Compare
LucasWerey
reviewed
Dec 6, 2024
apps/ledger-live-desktop/src/renderer/reducers/dynamicContent.ts
Outdated
Show resolved
Hide resolved
themooneer
force-pushed
the
fix/LIVE-15007
branch
from
c1a9ed3 to
5c80269
Compare
themooneer
force-pushed
the
fix/LIVE-15007
branch
from
5c80269 to
9a01b8f
Compare
themooneer
force-pushed
the
fix/LIVE-15007
branch
from
9a01b8f to
a129fab
Compare
DatDraggy
pushed a commit
to DatDraggy/ledger-live
that referenced
this pull request
Jan 6, 2025
This was referenced Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Even when the user opt-out from analytics, it can happen that braze campaign target anonymous user via (anonymous_user_id), in this case notification impression/seen process won't be made by calling the tracking/impression request (as it's an opt-out mode). As a reinforcement layer for this scenario, LLD should support the fact that this notification is read via an store/offline indexation process.
Content card's view state will be conditioned by braze metadata and their existence or not in the
anonymousUserNotificationsstore.Test proof 📹
notif_OK_p1.mov
❓ Context
https://ledgerhq.atlassian.net/browse/LIVE-15007
🧐 Checklist for the PR Reviewers