Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing names regression in staking modal #8593

Merged
merged 1 commit into from
Dec 4, 2024
Merged

fix: missing names regression in staking modal #8593

merged 1 commit into from
Dec 4, 2024

Conversation

marcotoniut-ledger
Copy link
Contributor

@marcotoniut-ledger marcotoniut-ledger commented Dec 3, 2024 •
edited by jira bot
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:

📝 Description

Fix missing names regression in staking modal

Before:

Screenshot 2024-12-03 at 20 50 00

After:

Screenshot 2024-12-03 at 21 04 00

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@marcotoniut-ledger marcotoniut-ledger requested a review from a team as a code owner December 3, 2024 21:08
@vercel Vercel
Copy link

vercel bot commented Dec 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Dec 3, 2024 9:09pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 3, 2024 9:09pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 3, 2024 9:09pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Dec 3, 2024 9:09pm

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Dec 3, 2024
@marcotoniut-ledger marcotoniut-ledger force-pushed the CN-959-provider-names-not-showing-on-eth-staking-modal-regression branch from 6a7c7c4 to da03766 Compare December 3, 2024 21:08
@marcotoniut-ledger marcotoniut-ledger merged commit 4f80505 into develop Dec 4, 2024
53 checks passed
@marcotoniut-ledger marcotoniut-ledger deleted the CN-959-provider-names-not-showing-on-eth-staking-modal-regression branch December 4, 2024 10:16
DatDraggy pushed a commit to DatDraggy/ledger-live that referenced this pull request Jan 6, 2025
@marcotoniut-ledger @DatDraggy
fix: missing names regression in staking modal (LedgerHQ#8593)
f35f9e0
This was referenced Jan 7, 2025
Merged
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beths-ledger beths-ledger beths-ledger approved these changes

@KVNLS KVNLS KVNLS approved these changes

Assignees

@marcotoniut-ledger marcotoniut-ledger

Labels
desktop Has changes in LLD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcotoniut-ledger @KVNLS @beths-ledger