fix: check if returnTo is defined #8516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
Justkant
previously approved these changes
Nov 28, 2024
| @@ -60,14 +60,15 @@ export function LiveApp({ match, appId: propsAppId, location }: Props) { | |||
| }, [search, customDappUrl, urlParams?.customDappUrl, internalParams?.customDappUrl]); | |||
|
|
|||
| const handleClose = useCallback(() => { | |||
| if (returnTo.startsWith("/swap")) { | |||
| if (typeof returnTo === "string" && returnTo.startsWith("/swap")) { | |||
There was a problem hiding this comment.
LGTM like that, another option could have been to simply do that
Suggested change
| if (typeof returnTo === "string" && returnTo.startsWith("/swap")) { | |
| if (returnTo?.startsWith("/swap")) { |
Also if you update the type in the memo above you can get typescript to show the undefined correctly as shown in the screenshot below
There was a problem hiding this comment.
Just pushed this change.
The video in the description is still valid after this commit, according to my tests
Justkant
approved these changes
Nov 28, 2024
liviuciulinaru
approved these changes
Nov 28, 2024
Couto
added a commit
that referenced
this pull request
Nov 28, 2024
* fix: check if returnTo is defined * chore: add changeset * chore: accept suggestion
Couto
added a commit
that referenced
this pull request
Nov 28, 2024
fix: check if returnTo is defined (#8516) * fix: check if returnTo is defined * chore: add changeset * chore: accept suggestion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Check if
returnTois defined as a string before triggering the swap analytic.Some sections of the application do not provide a
returnTovalue.Screen.Recording.2024-11-28.at.08.57.16.mov
❓ Context
🧐 Checklist for the PR Reviewers