Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QAA] Updating send test (memo tag modal) for SOL and XRP #8469

Merged
merged 2 commits into from
Nov 25, 2024
Merged

[QAA] Updating send test (memo tag modal) for SOL and XRP #8469

merged 2 commits into from
Nov 25, 2024

Conversation

VicAlbr
Copy link
Contributor

@VicAlbr VicAlbr commented Nov 25, 2024 •
edited
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Updating test for new memoTag modal for SOL and XRP

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Nov 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Nov 25, 2024 3:50pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 25, 2024 3:50pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 25, 2024 3:50pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Nov 25, 2024 3:50pm

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Nov 25, 2024
@VicAlbr VicAlbr force-pushed the support/update-send-test-tagModal branch from 3f582af to 03af805 Compare November 25, 2024 15:44
@VicAlbr VicAlbr marked this pull request as ready for review November 25, 2024 15:47
@VicAlbr VicAlbr requested review from a team as code owners November 25, 2024 15:47
themooneer
themooneer approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@themooneer themooneer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VicAlbr VicAlbr merged commit a9edfa0 into develop Nov 25, 2024
40 of 43 checks passed
@VicAlbr VicAlbr deleted the support/update-send-test-tagModal branch November 25, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ypolishchuk-ledger ypolishchuk-ledger ypolishchuk-ledger approved these changes

@themooneer themooneer themooneer approved these changes

Assignees

@VicAlbr VicAlbr

Labels
desktop Has changes in LLD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VicAlbr @themooneer @ypolishchuk-ledger