-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Rework hiddenCollections to handle more easily displays #8457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git βοΈ
3 Skipped Deployments
|
mcayuelas-ledger
force-pushed
the
feat/improve-hidden-collections
branch
from
November 25, 2024 10:35
8d3dadd
to
3cee042
Compare
themooneer
reviewed
Nov 25, 2024
@themooneer For the moment no, Maybe we can see to improve that soon :) It's been a long time that this UI has been done, so maybe a refresh could be good ! |
mcayuelas-ledger
force-pushed
the
feat/improve-hidden-collections
branch
from
November 25, 2024 10:57
3cee042
to
53ad8b3
Compare
themooneer
reviewed
Nov 25, 2024
apps/ledger-live-desktop/src/renderer/hooks/nfts/useNftCollectionsStatus.ts
Show resolved
Hide resolved
mcayuelas-ledger
force-pushed
the
feat/improve-hidden-collections
branch
from
November 25, 2024 13:22
53ad8b3
to
f7b1c76
Compare
themooneer
previously approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mcayuelas-ledger
force-pushed
the
feat/improve-hidden-collections
branch
from
November 28, 2024 09:10
f7b1c76
to
4ebfc09
Compare
mcayuelas-ledger
force-pushed
the
feat/improve-hidden-collections
branch
from
November 29, 2024 15:25
4ebfc09
to
c10f439
Compare
themooneer
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
β Checklist
npx changeset
was attached.π Description
hiddenCollections
is now an object renamednftCollectionsStatusByNetwork
, containing the different contracts according to their network3 types of status :
FF-based display (nftFromSimpleHash) :
Screen.Recording.2024-11-25.at.11.16.10.1.mov
β Context
π§ Checklist for the PR Reviewers