Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Rework hiddenCollections to handle more easily displays #8457

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

mcayuelas-ledger
Copy link
Contributor

@mcayuelas-ledger mcayuelas-ledger commented Nov 25, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

hiddenCollections is now an object renamed nftCollectionsStatusByNetwork, containing the different contracts according to their network
3 types of status :

  • Spam => Spam filter automatically adds the contract to the object
  • Whitelisted => User manually removes contract from hiddenCollections
  • Blacklisted => User manually adds contract to hiddenCollections (Hide Collection)

FF-based display (nftFromSimpleHash) :

  • If ON => display only whitelisted NFTs in addition to others
  • If OFF => Whitelisted and Spam NFTs are displayed in addition to the others
Screen.Recording.2024-11-25.at.11.16.10.1.mov

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@mcayuelas-ledger mcayuelas-ledger requested a review from a team as a code owner November 25, 2024 10:34
Copy link

vercel bot commented Nov 25, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Nov 29, 2024 3:31pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2024 3:31pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2024 3:31pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2024 3:31pm

@themooneer
Copy link
Contributor

image (general question) When no hidden collection item, will it be more UX/UI friendly to add an indication that the list is empty ?

@mcayuelas-ledger
Copy link
Contributor Author

@themooneer For the moment no, Maybe we can see to improve that soon :)

It's been a long time that this UI has been done, so maybe a refresh could be good !

themooneer
themooneer previously approved these changes Nov 26, 2024
Copy link
Contributor

@themooneer themooneer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcayuelas-ledger mcayuelas-ledger merged commit d45e871 into develop Dec 2, 2024
52 of 53 checks passed
@mcayuelas-ledger mcayuelas-ledger deleted the feat/improve-hidden-collections branch December 2, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants