feat(LIVE-14948): remove CDN for release issues and thorswap as DEX #8436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
lpaquet-ledger
force-pushed
the
feat/LIVE-14948
branch
from
a6a20ac
to
34b9050
Compare
lpaquet-ledger
force-pushed
the
feat/LIVE-14948
branch
from
1f48c42
to
abb47ba
Compare
CremaFR
reviewed
Nov 22, 2024
CremaFR
reviewed
Nov 22, 2024
CremaFR
reviewed
Nov 22, 2024
CremaFR
reviewed
Nov 22, 2024
CremaFR
reviewed
Nov 22, 2024
CremaFR
reviewed
Nov 22, 2024
Comment on lines
53
to
55
| if (providerConfig.useInExchangeApp === true) { | ||
| throw new Error(`Unsupported provider type ${providerConfig.type}`); | ||
| } |
There was a problem hiding this comment.
you inverted the condition here .... I guess that's why all providers boolean where inverted too
Suggested change
| if (providerConfig.useInExchangeApp === true) { | |
| throw new Error(`Unsupported provider type ${providerConfig.type}`); | |
| } | |
| if (providerConfig.useInExchangeApp !== true) { | |
| throw new Error(`Unsupported provider type ${providerConfig.type}`); | |
| } |
feat(LIVE-14948): changeset feat(LIVE-14948): changeset feat(LIVE-14948): lint Update libs/ledger-live-common/src/exchange/providers/swap.ts Update libs/ledger-live-common/src/exchange/providers/swap.ts Update libs/ledger-live-common/src/exchange/providers/swap.ts Update libs/ledger-live-common/src/exchange/providers/swap.ts Update libs/ledger-live-common/src/exchange/providers/swap.ts feat(LIVE-14948): fix wrong condition
lpaquet-ledger
force-pushed
the
feat/LIVE-14948
branch
from
256ba43
to
dcc6662
Compare
CremaFR
approved these changes
Nov 25, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
remove CDN for release issues and thorswap as DEX
❓ Context
🧐 Checklist for the PR Reviewers