Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DISABLE_TRANSACTION_BROADCAST logic moved to tests suites #8385

Merged
merged 5 commits into from
Nov 22, 2024
Merged

DISABLE_TRANSACTION_BROADCAST logic moved to tests suites #8385

merged 5 commits into from
Nov 22, 2024
+452 −441

Conversation

bharamboure-ledger
Copy link
Contributor

@bharamboure-ledger bharamboure-ledger commented Nov 18, 2024 •
edited
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

DISABLE_TRANSACTION_BROADCAST logic moved from github workflow to tests suites

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Nov 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 9:56am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 9:56am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 9:56am
web-tools ⬜️ Ignored (Inspect) Nov 22, 2024 9:56am

@live-github-bot live-github-bot bot added desktop Has changes in LLD automation CI/CD stuff labels Nov 18, 2024
@bharamboure-ledger bharamboure-ledger marked this pull request as ready for review November 19, 2024 15:41
@bharamboure-ledger bharamboure-ledger requested review from a team as code owners November 19, 2024 15:41
@VicAlbr VicAlbr force-pushed the fix/ci-speculos-broadcast branch from e398fdc to 4d79dd2 Compare November 19, 2024 16:06
@bharamboure-ledger bharamboure-ledger marked this pull request as draft November 19, 2024 17:00
@bharamboure-ledger bharamboure-ledger marked this pull request as ready for review November 21, 2024 15:55
@bharamboure-ledger bharamboure-ledger merged commit 12ffbd5 into develop Nov 22, 2024
42 of 44 checks passed
@bharamboure-ledger bharamboure-ledger deleted the fix/ci-speculos-broadcast branch November 22, 2024 10:35
aboissiere-ledger pushed a commit that referenced this pull request Nov 22, 2024
@bharamboure-ledger @aboissiere-ledger
DISABLE_TRANSACTION_BROADCAST logic moved to tests suites (#8385)
4b523de 
* DISABLE_TRANSACTION_BROADCAST logic moved from github workflow to test suites
bharamboure-ledger added a commit that referenced this pull request Nov 26, 2024
@bharamboure-ledger
Revert "DISABLE_TRANSACTION_BROADCAST logic moved to tests suites (#8385
b806029 
)"

This reverts commit 12ffbd5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ypolishchuk-ledger ypolishchuk-ledger ypolishchuk-ledger left review comments

@abdurrahman-ledger abdurrahman-ledger abdurrahman-ledger approved these changes

Assignees

@bharamboure-ledger bharamboure-ledger

Labels
automation CI/CD stuff desktop Has changes in LLD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bharamboure-ledger @ypolishchuk-ledger @abdurrahman-ledger