Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QAA] Adding e2e test - User can send NFT to an ENS address #8378

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

VicAlbr
Copy link
Contributor

@VicAlbr VicAlbr commented Nov 15, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Adding e2e test => User can send an NFT to an ENS address

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Nov 15, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Nov 19, 2024 3:26pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 19, 2024 3:26pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 19, 2024 3:26pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Nov 19, 2024 3:26pm

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Nov 15, 2024
@VicAlbr VicAlbr force-pushed the support/QAA-326 branch 2 times, most recently from a49efc1 to e0a91e7 Compare November 15, 2024 14:36
@VicAlbr VicAlbr marked this pull request as ready for review November 15, 2024 14:52
@VicAlbr VicAlbr requested review from a team as code owners November 15, 2024 14:52
@VicAlbr VicAlbr merged commit 7ace824 into develop Nov 19, 2024
42 checks passed
@VicAlbr VicAlbr deleted the support/QAA-326 branch November 19, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants