No more setup toolchain (Github runners) batch 1 #8372
Merged
+26
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
live-github-bot
bot
added
ui
angusbayley
force-pushed
the
support/no-more-setup-toolchain-gh-runners-batch-1
branch
from
33af6cc
to
d5b6e64
Compare
angusbayley
force-pushed
the
support/no-more-setup-toolchain-gh-runners-batch-1
branch
from
8ea5a8b
to
6d973fc
Compare
angusbayley
commented
Nov 25, 2024
angusbayley
commented
Nov 25, 2024
angusbayley
commented
Nov 25, 2024
angusbayley
force-pushed
the
support/no-more-setup-toolchain-gh-runners-batch-1
branch
4 times, most recently
from
24fe3e7
to
262210c
Compare
angusbayley
force-pushed
the
support/no-more-setup-toolchain-gh-runners-batch-1
branch
from
262210c
to
ae1a9fb
Compare
angusbayley
changed the title
angusbayley
changed the title
This was referenced Nov 26, 2024
angusbayley
deleted the
support/no-more-setup-toolchain-gh-runners-batch-1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Migrates the first batch of workflows to
setup-cachesfromsetup-toolchain.To do this, we stay on the GH runners but force the proto download during
setup-caches. This costs about 10s but overall doesn't impact run time that much as GH runners outperform ours in several I/O limited steps (e.g. checkout).workflow testing
#8474 shows this PR with all this branch's workflows forced to run on the CI (I decided to do this in a separate PR this time to prevent a repeat of the issue we had earlier this afternoon). That PR's base is this branch, so the diffs are useful
performance
This is a win runtime-wise. The
setup-cachesstep in Test Docs is just 10s in this PR's run, vs 1m 51s in another workflow run without these changes applied. The switch does add ~20s to the install step that follows, giving a total saving of 1m 21s. This difference seems to be stable - randomly inspecting other jobs shows similar before/after differences for setup-caches (I've looked at about 5 before and 5 after so far).