Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fall back to firebase display name if no translated title #8343

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

beths-ledger
Copy link
Contributor

@beths-ledger beths-ledger commented Nov 11, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • Add a new staking provider to eth_staking_providers FF in firebase
    • Add "name" field
    • Given no translated "title", name of EVM staking provider appears as is on the list, to prevent i18n key from appearing instead.

📝 Description

We need to add providers faster than LL release cycle. Given that provider display names are brand names therefore not translated, fallback to the JSON-serialised "name" field from Firebase for any new provider.

Example

Expected behavior:
”Coinbase” should appear in the EVM staking modal with icon

image

Actual behavior:
i18n translation key stakingProviders.coinbase.title appears in the list

image

Note that we will only release new providers in this way after the rollout of the new EVM staking modal is 100%.

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@beths-ledger beths-ledger requested a review from a team as a code owner November 11, 2024 14:10
Copy link

vercel bot commented Nov 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 2:15pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 2:15pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 2:15pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 2:15pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM labels Nov 11, 2024
Justkant
Justkant previously approved these changes Nov 12, 2024
@beths-ledger beths-ledger force-pushed the fix/add-fall-name-for-staking-providers branch from 641abd6 to 2bca224 Compare November 12, 2024 14:14
@beths-ledger beths-ledger merged commit a99d671 into develop Nov 13, 2024
48 checks passed
@beths-ledger beths-ledger deleted the fix/add-fall-name-for-staking-providers branch November 13, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants