Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ›(lld): missing translations for network troubleshooting #8337

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

LucasWerey
Copy link
Contributor

@LucasWerey LucasWerey commented Nov 8, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • LLD settings

πŸ“ Description

Add missing translations for network troubleshooting modal in settings

Screen.Recording.2024-11-08.at.16.25.05.mov

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Nov 8, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools ❌ Failed (Inspect) Nov 8, 2024 3:38pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 3:38pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 3:38pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 3:38pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD common Has changes in live-common translations Translation files have been touched labels Nov 8, 2024
@LucasWerey LucasWerey marked this pull request as ready for review November 8, 2024 15:26
@LucasWerey LucasWerey requested a review from a team as a code owner November 8, 2024 15:26
@LucasWerey LucasWerey marked this pull request as draft November 8, 2024 15:27
@LucasWerey LucasWerey marked this pull request as ready for review November 8, 2024 15:29
@LucasWerey LucasWerey merged commit be27e15 into develop Nov 8, 2024
52 of 57 checks passed
@LucasWerey LucasWerey deleted the fix/LIVE-14829 branch November 8, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common desktop Has changes in LLD translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants