Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: notify exchangeSdk about closing the drawer #8319

Conversation

sergiubreban
Copy link
Contributor

@sergiubreban sergiubreban commented Nov 6, 2024

LLD test:

Screen.Recording.2024-11-07.at.08.37.37.mov

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bug fixes, you can explain the previous behaviour and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@sergiubreban sergiubreban requested a review from a team as a code owner November 6, 2024 14:38
Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2024 4:19am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2024 4:19am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2024 4:19am
web-tools ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2024 4:19am

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Nov 6, 2024
sarneijim
sarneijim previously approved these changes Nov 12, 2024
@Justkant Justkant requested a review from KVNLS November 18, 2024 09:03
@sergiubreban sergiubreban merged commit 42e9d67 into develop Nov 26, 2024
53 checks passed
@sergiubreban sergiubreban deleted the LIVE-14250-exchange-sdk-do-not-response-when-drawer-is-closed-in-lld branch November 26, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants