-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: notify exchangeSdk about closing the drawer #8319
Merged
sergiubreban
merged 4 commits into
develop
from
LIVE-14250-exchange-sdk-do-not-response-when-drawer-is-closed-in-lld
Nov 26, 2024
Merged
fix: notify exchangeSdk about closing the drawer #8319
sergiubreban
merged 4 commits into
develop
from
LIVE-14250-exchange-sdk-do-not-response-when-drawer-is-closed-in-lld
Nov 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
sarneijim
previously approved these changes
Nov 12, 2024
KVNLS
reviewed
Nov 12, 2024
apps/ledger-live-desktop/src/renderer/components/LiveAppDrawer.tsx
Outdated
Show resolved
Hide resolved
Justkant
approved these changes
Nov 14, 2024
sarneijim
approved these changes
Nov 15, 2024
CremaFR
approved these changes
Nov 18, 2024
KVNLS
approved these changes
Nov 26, 2024
sergiubreban
deleted the
LIVE-14250-exchange-sdk-do-not-response-when-drawer-is-closed-in-lld
branch
November 26, 2024 14:42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLD test:
Screen.Recording.2024-11-07.at.08.37.37.mov
✅ Checklist
npx changeset
was attached.📝 Description
Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bug fixes, you can explain the previous behaviour and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.
❓ Context
🧐 Checklist for the PR Reviewers