Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lld): localised URL #8194

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

fAnselmi-Ledger
Copy link
Contributor

@fAnselmi-Ledger fAnselmi-Ledger commented Oct 24, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Localised URL

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@fAnselmi-Ledger fAnselmi-Ledger requested a review from a team as a code owner October 24, 2024 12:09
Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Oct 24, 2024 0:10am
ledger-live-github-bot ⬜️ Ignored (Inspect) Oct 24, 2024 0:10am
native-ui-storybook ⬜️ Ignored (Inspect) Oct 24, 2024 0:10am
react-ui-storybook ⬜️ Ignored (Inspect) Oct 24, 2024 0:10am
web-tools ⬜️ Ignored (Inspect) Oct 24, 2024 0:10am

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Oct 24, 2024
Copy link
Contributor

There as been no activity on this PR for the last 14 days. Please consider closing this PR.

@github-actions github-actions bot added the Stale label Nov 14, 2024
@Justkant Justkant merged commit 3a485a1 into develop Nov 14, 2024
43 of 45 checks passed
@Justkant Justkant deleted the LIVE-11631-lld-onboarding-recover-outgoing-link branch November 14, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants