Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIVE-13681 chore: move stacks to its own module #8163

Merged
merged 53 commits into from
Nov 14, 2024

Conversation

Wozacosta
Copy link
Contributor

@Wozacosta Wozacosta commented Oct 22, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bug fixes, you can explain the previous behaviour and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@Wozacosta Wozacosta self-assigned this Oct 22, 2024
Copy link

vercel bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Nov 13, 2024 2:12pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 2:12pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 2:12pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 2:12pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 2:12pm

@Wozacosta Wozacosta force-pushed the support/coin-stacks-module branch from 3696780 to f64e173 Compare October 23, 2024 14:42
@live-github-bot live-github-bot bot added the common Has changes in live-common label Oct 23, 2024
@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM labels Oct 23, 2024
Copy link
Contributor

@mcayuelas-ledger mcayuelas-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for @LedgerHQ/live-hub

@Wozacosta Wozacosta merged commit 0b5ef53 into develop Nov 14, 2024
54 of 55 checks passed
@Wozacosta Wozacosta deleted the support/coin-stacks-module branch November 14, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants