Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ’„(lld): skip drawer and update copy #7850

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

LucasWerey
Copy link
Contributor

@LucasWerey LucasWerey commented Sep 19, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • Delete key flow

πŸ“ Description

Update delete key flow on LS
Update copy

Screen.Recording.2024-09-19.at.11.26.43.mov

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Sep 19, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2024 10:12am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2024 10:12am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2024 10:12am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2024 10:12am
web-tools ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2024 10:12am

@live-github-bot live-github-bot bot added desktop Has changes in LLD translations Translation files have been touched labels Sep 19, 2024
@LucasWerey LucasWerey marked this pull request as ready for review September 19, 2024 09:39
@LucasWerey LucasWerey requested review from a team as code owners September 19, 2024 09:39
@@ -6527,10 +6527,10 @@
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can remove

"options": {
        "deleteBackup": {
          "title": "Delete your backup",
          "description": "All synced accounts will be removed. This won’t affect your local accounts."
        }
      }

If I'm not wrong :)

Copy link
Contributor Author

@LucasWerey LucasWerey Sep 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes I missed that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

βœ…

"label": "Manage Key",
"description": "Secure or delete your encryption key via another Ledger."
"label": "Delete sync",
"description": "Your synched crypto accounts across different Ledger Live apps will stop synching."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

synced instead of synched

@LucasWerey LucasWerey merged commit 4ae8284 into develop Sep 19, 2024
39 of 41 checks passed
@LucasWerey LucasWerey deleted the fix/LIVE-14195 branch September 19, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants