Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👽fix(ll): update HC links #7819

Merged
merged 1 commit into from
Sep 17, 2024
Merged

👽fix(ll): update HC links #7819

merged 1 commit into from
Sep 17, 2024

Conversation

LucasWerey
Copy link
Contributor

@LucasWerey LucasWerey commented Sep 16, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • URLs

📝 Description

Update HC links from zendesk to salesforce
useLocalizedUrl has been updated to work with these new links. However if you already came in the support web page the localisation won't change anything because the site keep the previous langage. So useful only for the first time.

Some old harcoded urls remains on blockchain side and already redirect to nothing

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Sep 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Sep 16, 2024 3:25pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Sep 16, 2024 3:25pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 16, 2024 3:25pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 16, 2024 3:25pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Sep 16, 2024 3:25pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM labels Sep 16, 2024
@LucasWerey LucasWerey force-pushed the fix/LIVE-13922 branch 4 times, most recently from 1862539 to e0b08d2 Compare September 16, 2024 14:56
@LucasWerey LucasWerey marked this pull request as ready for review September 16, 2024 14:58
@LucasWerey LucasWerey requested a review from a team as a code owner September 16, 2024 14:58
@LucasWerey LucasWerey force-pushed the fix/LIVE-13922 branch 2 times, most recently from b8fac56 to 5d2ea87 Compare September 16, 2024 15:07
Copy link
Contributor Author

@LucasWerey LucasWerey Sep 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Git didn't like the changes here but it didn't change only delete SUPPORT_LANG
image

@LucasWerey LucasWerey requested a review from a team as a code owner September 16, 2024 15:21
@LucasWerey LucasWerey merged commit ace3185 into develop Sep 17, 2024
50 of 55 checks passed
@LucasWerey LucasWerey deleted the fix/LIVE-13922 branch September 17, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants