Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/live 13088 (#7163) #7174

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Fix/live 13088 (#7163) #7174

merged 1 commit into from
Jun 24, 2024

Conversation

CremaFR
Copy link
Member

@CremaFR CremaFR commented Jun 24, 2024

  • fix: rare crash where gasOption is defined but not yet in transaction where it should be

  • chore: changeset

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

cherry pick of #7163

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

* fix: rare crash where gasOption is defined but not yet in transaction where it should be

* chore: changeset
@CremaFR CremaFR requested a review from a team as a code owner June 24, 2024 11:50
Copy link

vercel bot commented Jun 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Jun 24, 2024 11:51am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jun 24, 2024 11:51am
native-ui-storybook ⬜️ Ignored (Inspect) Jun 24, 2024 11:51am
react-ui-storybook ⬜️ Ignored (Inspect) Jun 24, 2024 11:51am
web-tools ⬜️ Ignored (Inspect) Visit Preview Jun 24, 2024 11:51am

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Jun 24, 2024
@CremaFR CremaFR merged commit 7499a8b into release Jun 24, 2024
33 of 34 checks passed
@CremaFR CremaFR deleted the fix/LIVE-13088-release branch June 24, 2024 12:06
kallen-ledger pushed a commit that referenced this pull request Jun 26, 2024
* fix: rare crash where gasOption is defined but not yet in transaction where it should be

* chore: changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants