fix(llm): improve typing of ReceiveFunds/02-SelectAccount and fix crash case

[gre]

✅ Checklist

• npx changeset was attached.
• Covered by automatic tests.
  • no tests yet but covered by type safety that wasn't correctly made before my change, on the whole SelectAccount file.
• Impact of the changes:
  • Receive funds flow when selecting a token

📝 Description

Root cause: the rework of #6534

as seen here, we did a mistake on LLM ReceiveFunds/02-SelectAccount file where we passed a Currency instead of an Account on the getDefaultAccountName function.
unfortunately the bad typing was hiding the issue: bad casting using item.parentAccount as Account which hides the problem. because actually .parentAccount is a Account | undefined. since we didn't have the | undefined part, TypeScript will infer the code as a Account and not as an Account | Currency that is actually the type of the previously bad code here.

the fix:

❓ Context

• JIRA or GitHub link: https://ledgerhq.atlassian.net/browse/LIVE-13092

---

🧐 Checklist for the PR Reviewers

• The code aligns with the requirements described in the linked JIRA or GitHub issue.
• The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
• There are no undocumented trade-offs, technical debt, or maintainability issues.
• The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
• Any new dependencies have been justified and documented.
• Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
ledger-live-docs	⬜️ Ignored (Inspect)	Visit Preview		Jun 20, 2024 1:18pm
ledger-live-github-bot	⬜️ Ignored (Inspect)	Visit Preview		Jun 20, 2024 1:18pm
native-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview		Jun 20, 2024 1:18pm
react-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview		Jun 20, 2024 1:18pm
web-tools	⬜️ Ignored (Inspect)	Visit Preview		Jun 20, 2024 1:18pm

[KVNLS]

When I look at the Sentry error, the error happens in live-wallet/lib/accountName.js
Could make the function resilient, please?

const getDefaultAccountName = (account) => {
    if (account.type === "Account") {
        return (0, exports.getDefaultAccountNameForCurrencyIndex)(account);
    }
    return account.token.name;
};

Here we are not sure that we can access account.token.name.
Could you add the unit test to simulate the issue we had, please?

[gre]

@KVNLS the error is not in live-wallet, it's a misusage of the getDefaultAccountName function. Instead of giving an Account we have previously given a CryptoCurrency 😨 , so we didn't respected the type. and the error basically is like if you would given a bad object to any function.
the overusage of as casting has prevented the problem to be detected with type safety.

the getDefaultAccountName function

(account: AccountLike) => {
  if (account.type === "Account") {
    return getDefaultAccountNameForCurrencyIndex(account);
  }
  return account.token.name;
};

if type properly respected, should not fail.

Sorry, the rootcause wasn't fully clear, so I have updated the PR description with all details of why the error happened and the fact it was hidden by as Account which should have been a as Account | undefined. Now that the TypeScript is fixed, we can't have this situation where we accept again a currency instead of an account to the function, and indeed that function should not accept a Currency.

I didn't had enough time to make a proper end to end test on mobile and I suggest we proceed to taking this fix in the hotfix first, because properly testing the receive flow will take some time, there are many different cases I could see in the code (at least we had two cases to cover the two sides of this || , in this PR fix, I actually converged to just use the item's name)