Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/live 12863 telos explorer error #7078

Merged
merged 5 commits into from
Jun 14, 2024

Conversation

lvndry
Copy link
Contributor

@lvndry lvndry commented Jun 12, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests

πŸ“ Description

[EVM] Better error message if can't fetch list of operations

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@lvndry lvndry self-assigned this Jun 12, 2024
@lvndry lvndry requested a review from a team as a code owner June 12, 2024 12:33
Copy link

vercel bot commented Jun 12, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jun 13, 2024 0:57am
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Jun 13, 2024 0:57am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jun 13, 2024 0:57am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 13, 2024 0:57am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 13, 2024 0:57am

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM translations Translation files have been touched labels Jun 12, 2024
Justkant
Justkant previously approved these changes Jun 12, 2024
Copy link
Contributor

@Justkant Justkant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just a small nit pick if you want to modify it

libs/coin-modules/coin-evm/src/api/explorer/etherscan.ts Outdated Show resolved Hide resolved
@lvndry lvndry merged commit 993c5f2 into develop Jun 14, 2024
54 of 56 checks passed
@lvndry lvndry deleted the feat/live-12863-telos-explorer-error branch June 14, 2024 08:33
Copy link

sentry-io bot commented Jun 19, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ InvalidExplorerResponse: InvalidExplorerResponse init_types(libs/coin-modules/coin-evm/src/api/e... View Issue

Did you find this useful? React with a πŸ‘ or πŸ‘Ž

kallen-ledger pushed a commit that referenced this pull request Jun 26, 2024
* better error message when explorer error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants