[LIVE-12968][LLM] QueuedDrawer: if onClose changes, drawer shouldn't auto close #7068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Ignored Deployments
|
ofreyssinet-ledger
changed the title
ofreyssinet-ledger
force-pushed
the
bugfix/LIVE-12968-drawer-closing-immediately
branch
from
d49b971 to
17ad40e
Compare
KVNLS
approved these changes
Jun 11, 2024
Justkant
reviewed
Jun 11, 2024
apps/ledger-live-mobile/src/newArch/components/QueuedDrawer/TestScreens.tsx
Outdated
Show resolved
Hide resolved
Justkant
reviewed
Jun 11, 2024
Comment on lines
+93
to
+94
| onCloseRef.current && onCloseRef.current(); // hack to avoid triggering the useEffect below if the parent changes the onClose prop | ||
| }, []); |
There was a problem hiding this comment.
No problem with the hack here, just pointing out that they recently talked about useEvent for this kind of scenario
https://github.com/reactjs/rfcs/blob/useevent/text/0000-useevent.md
facebook/react#14099
There was a problem hiding this comment.
aaah interesting !
ofreyssinet-ledger
force-pushed
the
bugfix/LIVE-12968-drawer-closing-immediately
branch
from
17ad40e to
852b109
Compare
Justkant
approved these changes
Jun 12, 2024
ofreyssinet-ledger
deleted the
bugfix/LIVE-12968-drawer-closing-immediately
branch
Merged
3 tasks
ofreyssinet-ledger
added a commit
that referenced
this pull request
Jun 12, 2024
…ng-immediately-develop fix(llm/QueuedDrawer): QueuedDrawer shouldn't auto close (cherrypick of #7068 for develop)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
The property
onClosewas indirectly a dependency of theuseEffectthat triggers auto closing in some cleanup logic of theQueuedDrawercomponent.The solution is to keep
onClosein a ref in the component so that it can still be used in thatuseEffectwithout triggering the useEffect when its value changes.before.mp4
after.mp4
❓ Context
🧐 Checklist for the PR Reviewers