Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(llm) [DSDK-308]: nanox ble update #6970

Merged
merged 2 commits into from
Jun 4, 2024
Merged

feat(llm) [DSDK-308]: nanox ble update #6970

merged 2 commits into from
Jun 4, 2024

Conversation

valpinkman
Copy link
Member

@valpinkman valpinkman commented May 30, 2024 •
edited by jira bot
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • Nano X to use the new FW update flow (and enable BLE fw update as well)

📝 Description

Enable Nano X BLE fw update on LLM.

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented May 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2024 8:41am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2024 8:41am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2024 8:41am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2024 8:41am
web-tools ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2024 8:41am

@live-github-bot live-github-bot bot added mobile Has changes in LLM translations Translation files have been touched labels May 30, 2024
@valpinkman valpinkman force-pushed the feat/DSDK-308-nano-x-ble-update branch 4 times, most recently from 2051439 to f281bff Compare June 4, 2024 08:38
@valpinkman valpinkman marked this pull request as ready for review June 4, 2024 08:38
@valpinkman valpinkman requested review from a team as code owners June 4, 2024 08:38
@valpinkman valpinkman force-pushed the feat/DSDK-308-nano-x-ble-update branch from f281bff to b5c892c Compare June 4, 2024 08:40
aussedatlo
aussedatlo approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@aussedatlo aussedatlo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@valpinkman valpinkman merged commit e3d6df4 into develop Jun 4, 2024
35 of 37 checks passed
@valpinkman valpinkman deleted the feat/DSDK-308-nano-x-ble-update branch June 4, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aussedatlo aussedatlo aussedatlo approved these changes

@cgrellard-ledger cgrellard-ledger cgrellard-ledger approved these changes

Assignees

@valpinkman valpinkman

Labels
mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@valpinkman @cgrellard-ledger @aussedatlo