Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/live 12794 restore transport race error #6963

Merged
merged 3 commits into from
May 30, 2024
Merged

Bugfix/live 12794 restore transport race error #6963

merged 3 commits into from
May 30, 2024

Conversation

aussedatlo
Copy link
Contributor

@aussedatlo aussedatlo commented May 29, 2024 •
edited by gre
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Restore TransportRaceCondition error that was renamed by TransportPendingOperation but was causing a unwanted breaking change.

Revert the commit 931d511

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented May 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2024 1:08pm
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview May 29, 2024 1:08pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview May 29, 2024 1:08pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 29, 2024 1:08pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 29, 2024 1:08pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs translations Translation files have been touched labels May 29, 2024
@aussedatlo aussedatlo force-pushed the bugfix/LIVE-12794-restore-transport-race-error branch from a9b0046 to 46aa988 Compare May 29, 2024 12:42
@aussedatlo aussedatlo linked an issue May 29, 2024 that may be closed by this pull request
[Bug]: Incompatible with @ledgerhq/errors #6882
Closed
@aussedatlo aussedatlo marked this pull request as ready for review May 29, 2024 12:53
@aussedatlo aussedatlo requested review from a team as code owners May 29, 2024 12:53
aussedatlo added 3 commits May 29, 2024 15:04
@aussedatlo
fix(errors): restore TransportRaceCondition
d2ad51c 
This reverts commit 931d511 that renamed TransportRaceCondition to TransportPendingOperation and causing a unwanted breaking change.
@aussedatlo
fix(errors): enable all unit tests
0e7fe3b
@aussedatlo
chore: changeset
815ae3d
@aussedatlo aussedatlo force-pushed the bugfix/LIVE-12794-restore-transport-race-error branch from 46aa988 to 815ae3d Compare May 29, 2024 13:04
@aussedatlo
Copy link
Contributor Author

This PR should fix #6882

@aussedatlo aussedatlo merged commit f2ea707 into develop May 30, 2024
58 of 60 checks passed
@aussedatlo aussedatlo deleted the bugfix/LIVE-12794-restore-transport-race-error branch May 30, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiyuzhuang jiyuzhuang jiyuzhuang approved these changes

@gre gre gre approved these changes

Assignees

@aussedatlo aussedatlo

Labels
common Has changes in live-common desktop Has changes in LLD ledgerjs Has changes in the ledgerjs open source libs mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Incompatible with @ledgerhq/errors
3 participants
@aussedatlo @gre @jiyuzhuang