-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove unused Account#endpointConfig field #6521
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
4 Ignored Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gre I don't know if we want to clean up in libs/ledger-live-common/src/families/ripple/api/index.ts
@getServerInfo
usage of endpointConfig
, is it intentional to keep it?
@KVNLS indeed the function still allows to configure the endpoint, but I did not want to be too intrusively touching the coin implementation in these sunset, only disconnecting them from the UI. because maybe @LedgerHQ/live-blockchain-support will have better ways to change this in future too (like connect it to something else like an env or a live-config dynamics') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
β Checklist
npx changeset
was attached. (no need)π Description
the
.endpointConfig
on Account type is unused since around 2020, we used it in the past to workaround problem on the XRP synchronisations that had unstable backends back then and we used to have a way accessible in the UI to configure the server. it's long gone so we can remove this unused tech debt.β Context
π§ Checklist for the PR Reviewers