Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[B2CQA-2125] Detox: fix add account tests #6072

Merged
merged 1 commit into from
Feb 2, 2024
Merged

[B2CQA-2125] Detox: fix add account tests #6072

merged 1 commit into from
Feb 2, 2024

Conversation

abdurrahman-ledger
Copy link
Contributor

@abdurrahman-ledger abdurrahman-ledger commented Feb 1, 2024 •
edited
Loading

📝 Description

Add account tests fails because a content card prevents to reach the button

  • Adding Scroll to the CTA to prevent test failure
  • Improving some tests ids

❓ Context

✅ Checklist

Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready.

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • Detox tests

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@abdurrahman-ledger abdurrahman-ledger requested review from a team as code owners February 1, 2024 14:20
@vercel Vercel
Copy link

vercel bot commented Feb 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Feb 2, 2024 11:52am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Feb 2, 2024 11:52am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 2, 2024 11:52am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 2, 2024 11:52am
web-tools ⬜️ Ignored (Inspect) Visit Preview Feb 2, 2024 11:52am

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Feb 1, 2024
@abdurrahman-ledger abdurrahman-ledger force-pushed the support/B2CQA-2125_detox_fix_addAccount_tests branch 2 times, most recently from 3d4c0a6 to b576f34 Compare February 1, 2024 15:10
@abdurrahman-ledger abdurrahman-ledger force-pushed the support/B2CQA-2125_detox_fix_addAccount_tests branch from b576f34 to 494cac4 Compare February 2, 2024 11:51
@abdurrahman-ledger abdurrahman-ledger merged commit 0fc0718 into develop Feb 2, 2024
36 checks passed
@abdurrahman-ledger abdurrahman-ledger deleted the support/B2CQA-2125_detox_fix_addAccount_tests branch February 2, 2024 12:51
jdabbech-ledger pushed a commit that referenced this pull request Feb 19, 2024
@abdurrahman-ledger @jdabbech-ledger
Merge pull request #6072 from LedgerHQ/support/B2CQA-2125_detox_fix_a…
f891314 
…ddAccount_tests

[B2CQA-2125] Detox: fix add account tests
jdabbech-ledger pushed a commit that referenced this pull request Feb 19, 2024
@abdurrahman-ledger @jdabbech-ledger
Merge pull request #6072 from LedgerHQ/support/B2CQA-2125_detox_fix_a…
502eedc 
…ddAccount_tests

[B2CQA-2125] Detox: fix add account tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gre gre gre approved these changes

Assignees

@abdurrahman-ledger abdurrahman-ledger

Labels
mobile Has changes in LLM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abdurrahman-ledger @gre