Upgrade react-native to 0.68.2 #435

ofreyssinet-ledger · 2022-06-22T13:20:35Z

Disclaimer

Yes I know that RN 0.69.0 was released last week 😬 but I was already working on this and it's a 1st step forward that is needed to unblock us on some topics (see below).

📝 Description

I'm doing this because we would like to be ready for [email protected] (which requires [email protected]) when it releases (right now it's in alpha) as it will solve a dependency conflict with storyly-react-native which we would like to use.

Main changes:

Upgraded react-native to 0.68.2, following this guide and picked what works for us:
- we don't upgrade Flipper as it crashes on runtime
- we don't upgrade gradle as it builds fine like this and v7 didn't work out of the box
- we don't keep react-native-gradle-plugin as it's only necessary for the new architecture..
- we don't change AppDelegate.m to the new AppDelegate.mm as it's only useful for the new RN arch which we aren't using yet + it was a pain to migrate the existing config (Firebase, Flipper, splash screen)
Upgraded react-native-reanimated to 2.8.0
Upgraded lottie-react-native to 5.1.3 as it was not building on iOS without upgrading -> I tested the device lotties in the "Debug Lottie" menu and it seems to work fine.
Upgraded react-native-gesture-handler to 2.5.0 & Migrating off RNGHEnabledRootView as its setup on Android (in MainActivity.java) might conflict with react-native stuff later on
Fixed an issue in the portfolio where if there was no assets, scrolling was crashing the app on iOS. This is a mysterious issue and the logs are similar to this issue [iOS] ScrollView event fatal crash software-mansion/react-native-reanimated#2285, for now it has been solved by removing the animation of a border width (border which anyway was invisible so the animation was pointless).

What I tested:

I didn't test much of the app after fixing the obvious crashes & issues, just tested the very basic functionality of the app on real device for both platforms + things known to be susceptible to break while upgrading react-native (following list). A full round of non-regression testing will have to be done on both platforms before merging.

TODO

fix Firebase features not found on iOS (broken config)
upgrade react-native-gesture-handler and Migrating off RNGHEnabledRootView as its setup on Android (in MainActivity.java) might conflict with react-native stuff later on.
better documentation of this PR (document individual changes for easy code review)
changesets
fix CI builds:

Issues detected but not a regression (already happening on prev versions of RN):

iOS crash with react-native-reanimated in scrollView handleScroll when interpolating an animated value
[iOS] ScrollView event fatal crash software-mansion/react-native-reanimated#2285
[interpolate] Exception NSException * "Mouting block is expected to not be set" software-mansion/react-native-reanimated#2764
- try applying patch from Fix deadlock in REANodesManager (removes synchronous UI updates) software-mansion/react-native-reanimated#3194
  -> it makes the scroll a bit jittery so not ideal
⚠️⚠️ iOS crash on market detail page if scrolling up & down quickly (linked to the issue above & ScrollContainerHeader)

❓ Context

Impacted projects: ledger-live-mobile
Linked resource(s): FAT-165

✅ Checklist

Test coverage
Atomic delivery
No breaking changes

A full round of non-regression testing will have to be done on both platforms before merging.

📸 Demo

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

live-github-bot · 2022-06-22T13:20:37Z

❌ @ofreyssinet-ledger

Unfortunately this PR does not comply with the Contributing Conventions and will be closed automatically.

Feel free to reopen this PR once you have browsed through the guidelines.

Found Issues:

the description is missing or you removed or overrode one or more sections of the pull request template

changeset-bot · 2022-06-22T13:20:38Z

🦋 Changeset detected

Latest commit: 8319ff4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
live-mobile	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2022-06-22T13:20:39Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
live-common-tools	✅ Ready (Inspect)	Visit Preview	Jul 18, 2022 at 0:49AM (UTC)

3 Ignored Deployments

Name	Status	Updated
ledger-live-github-bot	⬜️ Ignored (Inspect)	Jul 18, 2022 at 0:49AM (UTC)
native-ui-storybook	⬜️ Ignored (Inspect)	Jul 18, 2022 at 0:49AM (UTC)
react-ui-storybook	⬜️ Ignored (Inspect)	Jul 18, 2022 at 0:49AM (UTC)

github-actions · 2022-06-22T13:46:50Z

@ofreyssinet-ledger

Screenshots: ✅

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

codecov · 2022-06-22T13:49:53Z

Codecov Report

Merging #435 (8319ff4) into develop (bad1450) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #435      +/-   ##
===========================================
- Coverage    47.69%   47.68%   -0.01%     
===========================================
  Files          613      613              
  Lines        27277    27277              
  Branches      6827     6827              
===========================================
- Hits         13009    13008       -1     
- Misses       14208    14209       +1     
  Partials        60       60

Flag	Coverage Δ
test	`47.68% <ø> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
libs/ledger-live-common/src/range.ts	`94.87% <0.00%> (-2.57%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bad1450...8319ff4. Read the comment docs.

ofreyssinet-ledger · 2022-06-28T16:24:50Z

libs/ledger-live-common/mobile-test-app/android/.project

@@ -14,4 +14,15 @@
 	<natures>
 		<nature>org.eclipse.buildship.core.gradleprojectnature</nature>
 	</natures>
+	<filteredResources>


tbh I don't know what this is and why it changed 😬

ofreyssinet-ledger · 2022-06-28T16:27:02Z

apps/ledger-live-mobile/android/app/src/main/java/com/ledger/live/MainActivity.java

-        return new ReactActivityDelegateWrapper(this, new ReactActivityDelegate(this, getMainComponentName()) {
-            @Override
-            protected ReactRootView createRootView() {
-                return new RNGestureHandlerEnabledRootView(MainActivity.this);


See following section in PR description:

Upgraded react-native-gesture-handler to 2.5.0 & Migrating off RNGHEnabledRootView as its setup on Android (in MainActivity.java) might conflict with react-native stuff later on

ofreyssinet-ledger · 2022-06-28T16:29:40Z

apps/ledger-live-mobile/android/gradlew

@@ -1,7 +1,7 @@
-#!/usr/bin/env sh
+#!/bin/sh


file taken from upgrade tool

ofreyssinet-ledger · 2022-06-28T16:30:52Z

apps/ledger-live-mobile/ios/ledgerlivemobile/AppDelegate.m

@@ -121,7 +121,7 @@ - (void)applicationDidEnterBackground:(UIApplication *)application {
 - (NSURL *)sourceURLForBridge:(RCTBridge *)bridge
 {
 #if DEBUG
-  return [[RCTBundleURLProvider sharedSettings] jsBundleURLForBundleRoot:@"index" fallbackResource:nil];
+  return [[RCTBundleURLProvider sharedSettings] jsBundleURLForBundleRoot:@"index"];


fix necessary to build on RN 0.68.2, see facebook/react-native#33451 (comment)

ofreyssinet-ledger · 2022-06-28T16:31:32Z

apps/ledger-live-mobile/src/index.js

@@ -183,7 +183,7 @@ function App({ importDataString }: AppProps) {
  });

  return (
-    <View style={styles.root}>
+    <GestureHandlerRootView style={styles.root}>


See following section of PR description

Upgraded react-native-gesture-handler to 2.5.0 & Migrating off RNGHEnabledRootView as its setup on Android (in MainActivity.java) might conflict with react-native stuff later on

ofreyssinet-ledger · 2022-06-28T16:32:04Z

apps/ledger-live-mobile/src/screens/Portfolio/Header.tsx

@@ -96,38 +96,13 @@ function PortfolioHeader({
    };
  }, [graphCardEndPosition]);

-  const ContainerStyle = useAnimatedStyle(() => {


See following section of PR description:

Fixed an issue in the portfolio where if there was no assets, scrolling was crashing the app on iOS. This is a mysterious issue and the logs are similar to this issue [iOS] ScrollView event fatal crash software-mansion/react-native-reanimated#2285, for now it has been solved by removing the animation of a border width (border which anyway was invisible so the animation was pointless).

Justkant

LGTM, tested on a real android device and the ios simulator

elbywan

LGTM! 👍 👌

gre · 2022-07-15T14:53:31Z

very impressive work @ofreyssinet-ledger , i hope you manage to fix all remaining topics 🤞

ofreyssinet-ledger · 2022-07-15T15:02:57Z

@gre haha thanks! It's painful work but I think I'm finally done 🤞 at least with what QA detected in their last test:

an issue with Cosmos send: that was because of a wrong conflict resolution of the pnpm lock file when I rebased countless times this PR on develop 😅 That caused the installation of a wrong version of the Cosmos SDK I believe.
there was another issue with an animation in the RatingsModal on iOS, probably due to the upgrade of react-native-reanimated, I just fixed it.

use JDK 11 in build-mobile tmp fix for flow error (#663) flow Fix anim issue in RatingsModal Fix post rebase

live-github-bot bot closed this Jun 22, 2022

github-actions bot assigned ofreyssinet-ledger Jun 22, 2022

github-actions bot added the mobile Has changes in LLM label Jun 22, 2022

ofreyssinet-ledger reopened this Jun 22, 2022

ofreyssinet-ledger changed the title ~~Support/upgrade react-native to 0.68.2 (WIP)~~ Upgrade react-native to 0.68.2 Jun 27, 2022

vercel bot had a problem deploying to Preview – live-common-tools June 28, 2022 11:25 Failure

vercel bot had a problem deploying to Preview – live-common-tools June 28, 2022 14:06 Failure

vercel bot had a problem deploying to Preview – live-common-tools June 28, 2022 15:58 Failure

vercel bot had a problem deploying to Preview – live-common-tools June 28, 2022 16:09 Failure

vercel bot had a problem deploying to Preview – live-common-tools June 28, 2022 16:24 Failure

ofreyssinet-ledger commented Jun 28, 2022

View reviewed changes

ofreyssinet-ledger marked this pull request as ready for review June 28, 2022 16:32

ofreyssinet-ledger marked this pull request as draft June 28, 2022 16:32

ofreyssinet-ledger force-pushed the support/upgrade-rn-0.68.2 branch from bf0c4c0 to 8489d46 Compare June 28, 2022 16:42

vercel bot deployed to Preview – live-common-tools June 28, 2022 16:45 View deployment

vercel bot deployed to Preview – live-common-tools June 28, 2022 17:08 View deployment

github-actions bot added the automation CI/CD stuff label Jun 29, 2022

vercel bot deployed to Preview – live-common-tools June 29, 2022 09:25 View deployment

vercel bot deployed to Preview – live-common-tools June 29, 2022 12:23 View deployment

vercel bot deployed to Preview – live-common-tools June 29, 2022 12:46 View deployment

Justkant approved these changes Jun 30, 2022

View reviewed changes

elbywan approved these changes Jun 30, 2022

View reviewed changes

ofreyssinet-ledger force-pushed the support/upgrade-rn-0.68.2 branch from 3dcd365 to 59fce81 Compare June 30, 2022 15:36

vercel bot deployed to Preview – live-common-tools June 30, 2022 15:39 View deployment

ofreyssinet-ledger mentioned this pull request Jul 5, 2022

(REVERTED) Support/FAT-166 FAT-167 Storyly Integration #576

Merged

3 tasks

ofreyssinet-ledger force-pushed the support/upgrade-rn-0.68.2 branch from 59fce81 to ebeed76 Compare July 6, 2022 17:20

vercel bot had a problem deploying to Preview – live-common-tools July 6, 2022 17:23 Failure

ofreyssinet-ledger force-pushed the support/upgrade-rn-0.68.2 branch from ebeed76 to 9358832 Compare July 7, 2022 14:03

vercel bot had a problem deploying to Preview – live-common-tools July 7, 2022 14:06 Failure

ofreyssinet-ledger mentioned this pull request Jul 12, 2022

Support/FAT-166 FAT-167 Storyly Integration #633

Merged

3 tasks

ofreyssinet-ledger force-pushed the support/upgrade-rn-0.68.2 branch from 9358832 to b1cb93d Compare July 15, 2022 09:58

vercel bot had a problem deploying to Preview – live-common-tools July 15, 2022 09:59 Failure

ofreyssinet-ledger force-pushed the support/upgrade-rn-0.68.2 branch from b1cb93d to 79250a5 Compare July 15, 2022 10:20

vercel bot had a problem deploying to Preview – live-common-tools July 15, 2022 10:22 Failure

ofreyssinet-ledger force-pushed the support/upgrade-rn-0.68.2 branch from 79250a5 to ea9fdcf Compare July 15, 2022 13:24

vercel bot deployed to Preview – live-common-tools July 15, 2022 13:29 View deployment

vercel bot deployed to Preview – live-common-tools July 15, 2022 13:43 View deployment

ofreyssinet-ledger force-pushed the support/upgrade-rn-0.68.2 branch from deb8ba0 to e2c6267 Compare July 15, 2022 13:45

vercel bot deployed to Preview – live-common-tools July 15, 2022 13:46 View deployment

gre approved these changes Jul 15, 2022

View reviewed changes

vercel bot deployed to Preview – live-common-tools July 15, 2022 14:59 View deployment

ofreyssinet-ledger force-pushed the support/upgrade-rn-0.68.2 branch from ae447f9 to bc6a348 Compare July 18, 2022 10:08

vercel bot deployed to Preview – live-common-tools July 18, 2022 10:11 View deployment

Upgrade to react-native 0.68.2

8319ff4

use JDK 11 in build-mobile tmp fix for flow error (#663) flow Fix anim issue in RatingsModal Fix post rebase

ofreyssinet-ledger force-pushed the support/upgrade-rn-0.68.2 branch from bc6a348 to 8319ff4 Compare July 18, 2022 12:41

vercel bot deployed to Preview – live-common-tools July 18, 2022 12:49 View deployment

ofreyssinet-ledger merged commit cc3278d into develop Jul 18, 2022

ofreyssinet-ledger deleted the support/upgrade-rn-0.68.2 branch July 18, 2022 14:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade react-native to 0.68.2 #435

Upgrade react-native to 0.68.2 #435

ofreyssinet-ledger commented Jun 22, 2022 •

edited

Loading

live-github-bot bot commented Jun 22, 2022

changeset-bot bot commented Jun 22, 2022 •

edited

Loading

vercel bot commented Jun 22, 2022 •

edited

Loading

github-actions bot commented Jun 22, 2022 •

edited

Loading

codecov bot commented Jun 22, 2022 •

edited

Loading

ofreyssinet-ledger Jun 28, 2022

ofreyssinet-ledger Jun 28, 2022

ofreyssinet-ledger Jun 28, 2022 •

edited

Loading

ofreyssinet-ledger Jun 28, 2022

ofreyssinet-ledger Jun 28, 2022

ofreyssinet-ledger Jun 28, 2022

Justkant left a comment

elbywan left a comment

gre commented Jul 15, 2022 •

edited

Loading

ofreyssinet-ledger commented Jul 15, 2022

		@@ -1,7 +1,7 @@
		#!/usr/bin/env sh
		#!/bin/sh

Upgrade react-native to 0.68.2 #435

Upgrade react-native to 0.68.2 #435

Conversation

ofreyssinet-ledger commented Jun 22, 2022 • edited Loading

Disclaimer

📝 Description

Main changes:

What I tested:

TODO

❓ Context

✅ Checklist

📸 Demo

🚀 Expectations to reach

live-github-bot bot commented Jun 22, 2022

Unfortunately this PR does not comply with the Contributing Conventions and will be closed automatically.

changeset-bot bot commented Jun 22, 2022 • edited Loading

🦋 Changeset detected

vercel bot commented Jun 22, 2022 • edited Loading

github-actions bot commented Jun 22, 2022 • edited Loading

codecov bot commented Jun 22, 2022 • edited Loading

Codecov Report

ofreyssinet-ledger Jun 28, 2022

Choose a reason for hiding this comment

ofreyssinet-ledger Jun 28, 2022

Choose a reason for hiding this comment

ofreyssinet-ledger Jun 28, 2022 • edited Loading

Choose a reason for hiding this comment

ofreyssinet-ledger Jun 28, 2022

Choose a reason for hiding this comment

ofreyssinet-ledger Jun 28, 2022

Choose a reason for hiding this comment

ofreyssinet-ledger Jun 28, 2022

Choose a reason for hiding this comment

Justkant left a comment

Choose a reason for hiding this comment

elbywan left a comment

Choose a reason for hiding this comment

gre commented Jul 15, 2022 • edited Loading

ofreyssinet-ledger commented Jul 15, 2022

ofreyssinet-ledger commented Jun 22, 2022 •

edited

Loading

changeset-bot bot commented Jun 22, 2022 •

edited

Loading

vercel bot commented Jun 22, 2022 •

edited

Loading

github-actions bot commented Jun 22, 2022 •

edited

Loading

codecov bot commented Jun 22, 2022 •

edited

Loading

ofreyssinet-ledger Jun 28, 2022 •

edited

Loading

gre commented Jul 15, 2022 •

edited

Loading