Skip to content

Commit

Permalink
DISABLE_TRANSACTION_BROADCAST logic moved to tests suites (#8458)
Browse files Browse the repository at this point in the history
  • Loading branch information
bharamboure-ledger authored Nov 26, 2024
1 parent 627d8de commit afce01c
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 6 deletions.
1 change: 0 additions & 1 deletion apps/ledger-live-desktop/tests/fixtures/common.ts
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,6 @@ export const test = base.extend<TestFixtures>({
FEATURE_FLAGS: JSON.stringify(featureFlags),
MANAGER_DEV_MODE: IS_NOT_MOCK ? true : undefined,
SPECULOS_API_PORT: IS_NOT_MOCK ? getEnv("SPECULOS_API_PORT")?.toString() : undefined,
DISABLE_TRANSACTION_BROADCAST: !IS_NOT_MOCK ? undefined : 1,
},
env,
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ const validators = [

test.describe("Delegate flows", () => {
test.beforeAll(async () => {
process.env.ENABLE_TRANSACTION_BROADCAST =
new Date().getDay() === 1 && isRunningInScheduledWorkflow() ? "1" : "0";
process.env.DISABLE_TRANSACTION_BROADCAST =
new Date().getDay() === 1 && isRunningInScheduledWorkflow() ? "0" : "1";
});
for (const account of e2eDelegationAccounts) {
test.describe("Delegate", () => {
Expand Down
4 changes: 2 additions & 2 deletions apps/ledger-live-desktop/tests/specs/speculos/send.tx.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -213,8 +213,8 @@ const tokenTransactionInvalid = [

test.describe("Send flows", () => {
test.beforeAll(async () => {
process.env.ENABLE_TRANSACTION_BROADCAST =
new Date().getDay() === 1 && isRunningInScheduledWorkflow() ? "1" : "0";
process.env.DISABLE_TRANSACTION_BROADCAST =
new Date().getDay() === 1 && isRunningInScheduledWorkflow() ? "0" : "1";
});
//Warning 🚨: Test may fail due to the GetAppAndVersion issue - Jira: LIVE-12581 or insufficient funds

Expand Down
2 changes: 1 addition & 1 deletion apps/ledger-live-desktop/tests/specs/speculos/swap.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ for (const { swap, xrayTicket } of swaps) {
test.beforeAll(async () => {
process.env.SWAP_DISABLE_APPS_INSTALL = "true";
process.env.SWAP_API_BASE = "https://swap-stg.ledger-test.com/v5";
process.env.DISABLE_TRANSACTION_BROADCAST = "true";
process.env.DISABLE_TRANSACTION_BROADCAST = "1";
});

const accPair: string[] = [swap.accountToDebit, swap.accountToCredit].map(acc =>
Expand Down

0 comments on commit afce01c

Please sign in to comment.