Use Twisted 17.9.0 or higher #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 11, 2017
|
Thanks. As far as travis is concerned, this is basically not even a change. Twisted 17.9.0 != Twisted 17.1.0 so it was already testing against Twisted 17.9.0. The most recent build results bear this out, by being exactly the same on this branch and on master. When #150 is actually fixed, I would like the comment above the Twisted version constraint updated. I think the current comment is still reasonable for now though. So, merging. Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some backwards incompatible changes have been done with respect to endpoints and SSL, so target the newer version of Twisted.
See:
twisted/twisted@cd75dd8
twisted/twisted#611
twisted/twisted#624