Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validates context for activity. #7

Merged
merged 1 commit into from
Apr 12, 2016
Merged

Validates context for activity. #7

merged 1 commit into from
Apr 12, 2016

Conversation

ryasmi
Copy link
Member

@ryasmi ryasmi commented Aug 18, 2015

@ryasmi
Copy link
Member Author

ryasmi commented Apr 11, 2016

Any idea why this restriction is required @garemoko?

@ryasmi ryasmi added this to the 0.0.6 milestone Apr 11, 2016
@ryasmi ryasmi self-assigned this Apr 11, 2016
@garemoko
Copy link

@ryansmith94 there's no technical requirement disallowing statements from containing those properties with other objects and the LRS shouldn't reject them, but i can't think of a use case where those properties make sense where the object is an agent, statement reference or substatement.

Possibly if the object is an agent representing a robot or clone, then revision and even platform might make sense.

@garemoko
Copy link

Luke Skywalker reprogrammed R2D2, platform R2, revision D2.

@ryasmi
Copy link
Member Author

ryasmi commented Apr 11, 2016

@garemoko the spec states:

The revision property MUST only be used if the Statement's Object is an Activity.
The platform property MUST only be used if the Statement's Object is an Activity.

@garemoko
Copy link

@ryansmith94 ha. Good catch. No robot agents then.

@ryasmi
Copy link
Member Author

ryasmi commented Apr 11, 2016

Ok thanks @garemoko, I'll get this merged then.

@ryasmi ryasmi merged commit a239144 into master Apr 12, 2016
@ryasmi ryasmi deleted the issue/valid_context branch April 12, 2016 10:09
@ryasmi ryasmi modified the milestones: 0.0.7, 0.0.6 Apr 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants