-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dragged marker gets clustered when dragging&zooming above a cluster #808
Comments
Also reported to Leaflet: Leaflet/Leaflet#5638 Map getting stuck seems to be issue of theirs, but still a dragged marker should not get grouped while zooming in. |
hahaha, nice find. |
Haha yeah, the lockup is a Leaflet issue that seems to have been introduced in 1.1.0. But the issue here is that a marker that is being dragged will get clustered if you are dragging it above a cluster and zoom in/out. For example: Zoom fully in, start dragging a marker, then using the mouse wheel zoom out (and in again) while keeping the marker above a cluster: https://jsfiddle.net/3v7hd2vx/245/ In my application there are hundreds to thousands of markers on the map, user should be able to zoom in, pick a marker, then zoom out and move it somewhere else on the map. Would be also nice to be able to prevent that dragged marker getting clustered even after the drag until the user has confirmed the new location. |
Perhaps my PR #909 will also solve this problem, @jessenic can you test at https://jsfiddle.net/thy3c540/1/ ? |
This is improved now, but if the marker would get clustered at the zoom level you zoom out to it still gets merged (I think) |
Zooming out while dragging worked in my tests, but there is a problem when zooming in again. I will try to find out what goes wrong then and will try to provide a fix for this also, but it will take some time. |
Cool :)
…On Fri, 14 Sep 2018 at 5:54 PM, DerGuteWolf ***@***.***> wrote:
Zooming out while dragging worked in my tests, but there is a problem when
zooming in again. I will try to find out what goes wrong then and will try
to provide a fix for this also, but it will take some time.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#808 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAX_fsFnO8FIPjKJi9CioNYdLb1nnj9Tks5ua0SOgaJpZM4OaAIG>
.
|
How to reproduce
What behaviour I'm expecting and which behaviour I'm seeing
I'm expecting markers to be able to dragged and map to be zoomed. Dragged markers should not get clustered. But what seems to be happening is that the cluster will eat the marker if the marker is being dragged above it while zooming.
Minimal example reproducing the issue
For example this is taken from #685: https://jsfiddle.net/3v7hd2vx/245/
In this one the map doesn't get stuck, but the cluster is eating the marker which I believe causes the map getting stuck for me. (My map also got stuck if I removed a marker while it was being dragged)
After updating the fiddle to Leaflet 1.1.0, the map gets stuck like mine: https://jsfiddle.net/3v7hd2vx/343/
The text was updated successfully, but these errors were encountered: