Add aria-controls attribute to input element #17257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently using aria-owns attribute to relate input and listbox, per ARIA 1.0. Added use of aria-controls, per ARIA 1.1. Left aria-owns in place for B/C and also makes sense as list is a sibling of input anyway.
|
@LeaVerou Thanks for merging! Will this be in an update to the npm package or is it only distributed through https://projects.verou.me/awesomplete/? |
|
I guess I should publish it, it's been a long time! |
|
That'd be great, thank you! |
|
Done! Wow this package has some old stuff. |
|
Thanks for taking the time to update the package, it'll be useful! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently using aria-owns attribute to relate input and listbox, per ARIA 1.0. Added use of aria-controls, per ARIA 1.1.
Left aria-owns in place for B/C and also makes sense as list is a sibling of input anyway.