Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

container function to generate container element #17142

Closed
wants to merge 1 commit into from

Conversation

melitele
Copy link
Contributor

@melitele melitele commented May 27, 2018

I've added a container function to options that will allow client to provide a different container element. The default version of container function creates container element as before. I believe this is in line with the item function that customizes creating item elements.

This addresses my use case where container element cannot reuse the input element parent
because the input parent clips container's content. It also addresses a case when input element has to be next to it's original siblings.

It also solves #17086 & #16718

Thank you for consideration.

addresses a use case where container element cannot reuse input element parent
because input parent clips container content

also solves LeaVerou#17086
@melitele
Copy link
Contributor Author

I just noticed a bug - I'll fix it and resubmit the PR. My apologies.

@melitele melitele closed this May 27, 2018
@melitele melitele deleted the container-config branch May 27, 2018 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant