Fire awesomplete-highlight event only if some item was really highlighted #16872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| $.fire(this.input, "awesomplete-highlight", { | ||
| text: this.suggestions[this.index] |
There was a problem hiding this comment.
After the end/before the beginning, when this.index = -1 the text would be undefined.
Closed
LeaVerou
added a commit
that referenced
this pull request
Mar 16, 2016
Fire awesomplete-highlight event only if some item was really highlighted
|
Huh, no idea why it was like that, even though it was obviously intentional (otherwise I'd have put it in the conditional). Anyway, merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you move through the list with down/up keys
awesomplete-highlightis now triggered even after you reach the latest item and press down key again or you reach the first item and press up key again.In those 2 cases no item became highlighted, but
awesomplete-highlightevent is fired anyway. Is it a desired behavior or is it a bug?