allow users to create their own wrappers #16743
Conversation
| className: "awesomplete", | ||
| around: input | ||
| }); | ||
| this.container = input.parentNode.className.search(/awesomplete-wrapper/) >= 0 ? |
There was a problem hiding this comment.
why not classList.contains("awesomplete-wrapper")?
(if the answer is "browser support", IE9 can go fu…erm use a polyfill)
There was a problem hiding this comment.
Yep, that's why. Carries no real cost, so might as well.
|
Good idea, thanks! See comments. Sorry for the delay in replying. |
|
Has this been abandoned? I'd be happy to incorporate Lea's comments into this. Should I just open a new pull request as there seem to be conflicts with current code? |
|
Yeah, this PR seems to be abandoned. :( |
|
Is there a conflict or just these style pref comments? |
|
Just these style pref comments :) |
|
Cool. I moved to a different solution, but you're welcome to use the feature addition if someone wants to make the adaptations. |
This fixes #16718. Some layouts require the targeted input to remain siblings with other elements - this PR accommodates through the following changes:
awesomplete-wrapperclassawesompleteclass does not have such a wrapper at runtime, Awesomplete will make one just as before, albeit with theawesomplete-wrapperclass for consistency/simplicityMy apologies for not writing tests for this, didn't have time to get to it.