Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why there is no semver or release tags? #16873

Closed
emmenko opened this issue Mar 16, 2016 · 9 comments
Closed

Why there is no semver or release tags? #16873

emmenko opened this issue Mar 16, 2016 · 9 comments
Milestone

Comments

@emmenko
Copy link

emmenko commented Mar 16, 2016

Hey guys,

I've been using this library for a while and it works pretty well.

Unfortunately the lack of versioning / releases is really a problem.
The workaround of using the tip of the repository as a dependency is obviously very fragile. A simple breaking change can go easily unnoticed into production build because of the absence of a version.
Of course we could simply lock the dependency to a specific commit, but it's going to be hard then to "upgrade" as there is no related changelog to look at.

So my question is: why there is no versioning / release tags? I can live with the library not being published to npm, bower, etc, but having versions and keeping track of them should be a must IMHO.

Thanks

@vlazar
Copy link
Collaborator

vlazar commented Mar 16, 2016

There should be a 1.1 release soon. See https://github.com/LeaVerou/awesomplete/milestones/v1.1

@vlazar vlazar added this to the v1.1 milestone Mar 16, 2016
@emmenko
Copy link
Author

emmenko commented Mar 16, 2016

Ok, so is it planned to start using semver?

Thanks for the quick reply.

@vlazar
Copy link
Collaborator

vlazar commented Mar 16, 2016

@LeaVerou Speaking of server, should it be a 2.0 instead? There is a small known breaking change with suggestion item text API.

@emmenko
Copy link
Author

emmenko commented Mar 16, 2016

There is a small known breaking change with suggestion item text API.

That's the problem I discovered today :)

@vlazar
Copy link
Collaborator

vlazar commented Mar 16, 2016

That's the problem I discovered today :)

Can you please share, maybe it's something we don't know about yet?

@emmenko
Copy link
Author

emmenko commented Mar 16, 2016

Well, it's related to the change in #16866.

The replace function used to return a string but now it returns a Suggestion which is an object with { label, value }.

Wasn't that the "breaking change" you were talking about?

@vlazar
Copy link
Collaborator

vlazar commented Mar 16, 2016

Yes, did you had a problem with this or something else:

One known issue is that accessing suggestion's characters by index won't work with old API. It's easy to fix though. Instead of item[idx] use item.value[idx] or item.label[idx] directly.

@LeaVerou
Copy link
Owner

The replace function used to return a string but now it returns a Suggestion which is an object with { label, value }.

Did this break any of your old code? Its toString function makes it coerce into the old string when needed, but of course, it's still not bulletproof.

@vlazar
Copy link
Collaborator

vlazar commented Mar 16, 2016

The new version is 1.1 #16850 (comment)

@vlazar vlazar closed this as completed Mar 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants