Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated npm version #16850

Closed
powerbuoy opened this issue Feb 3, 2016 · 19 comments
Closed

Outdated npm version #16850

powerbuoy opened this issue Feb 3, 2016 · 19 comments
Milestone

Comments

@powerbuoy
Copy link

I get:
argument $saturation of hsl($hue, $saturation, $lightness) must be between 0 and 100

Backtrace:
node_modules/awesomplete/awesomplete.css:91, in function hsl

And here's what line 91 looks like:

background: hsl(68, 101%, 41%);

Would be lovely if this could be fixed so that we can keep awesomplete as a node module.

@vlazar
Copy link
Collaborator

vlazar commented Feb 3, 2016

Several issues:

  1. The awesomplete 1.0.0 npm package has been already published by some other guy 7 months ago https://www.npmjs.com/package/awesomplete
  2. The code in published 1.0.0 npm package it is very outdated - April 2015
  3. The 101% issue was fixed a long time ago in 815071c
  4. There are tons of other fixes and improvements since 1.0.0 made in this repo

@LeaVerou Can you please contact npm support and release new awesomplete package by yourself? There is no point releasing 1.0.0, since it's already released and version in package.json is 0.0.0 while git tag at this point is 1.0.0. So how about a 1.1.0 npm release with current code?

Handling Module Name Disputes
https://docs.npmjs.com/misc/disputes

Synopsis

Get the author email with npm owner ls
Email the author, CC [email protected]
After a few weeks, if there's no resolution, we'll sort it out.

There is also a bower.son, so I guess this should be also updated to 1.1.0 and match new 1.1.0 git tag.

I can prepare code for release, but I can't publish npm package for obvious reason.

@LeaVerou
Copy link
Owner

LeaVerou commented Feb 5, 2016

@stubbornella, perhaps you can help?

@vlazar vlazar added this to the v1.1 milestone Feb 6, 2016
@vlazar
Copy link
Collaborator

vlazar commented Mar 12, 2016

@LeaVerou @stubbornella Any progress on this?

@LeaVerou LeaVerou changed the title SASS won't compile because saturation is higher than 100 in hsl() Outdated npm version Mar 12, 2016
@LeaVerou
Copy link
Owner

I pinged her privately.

@LeaVerou
Copy link
Owner

The guy who published it on npm is @bequadrat.
@bequadrat, could you please transfer the npm package to me? Thanks!

@LeaVerou
Copy link
Owner

@vlazar I just npm published again, as the package was deleted, but now the version is 0.0.0! Why did we not have a sensible version in package.json?

@vlazar
Copy link
Collaborator

vlazar commented Mar 16, 2016

Lea, first of all, should it be 1.1 or 2.0 ? #16873 (comment)

Then I need to update package.json and add minified version. And update changeling, since you are trying to publish it now.

@LeaVerou
Copy link
Owner

I was publishing the previous version @vlazar, as @bequadrat unpublished it.

@LeaVerou
Copy link
Owner

And, I think the new version should be 1.1. It's not THAT huge of a change.

@vlazar
Copy link
Collaborator

vlazar commented Mar 16, 2016

OK, but there are breaking changes and people are asking about semver.

@vlazar
Copy link
Collaborator

vlazar commented Mar 16, 2016

I was publishing the previous version @vlazar, as @bequadrat unpublished it.

This version was published from the 1.0 tag and the version in package.json at this tag was 0.0.0

@vlazar
Copy link
Collaborator

vlazar commented Mar 16, 2016

Then I need to update package.json and add minified version. And update changeling, since you are trying to publish it now.

Done. Ready for 1.1.0.

@LeaVerou
Copy link
Owner

The version in package.json should be in sync with the git tag...
Anyhow, should I publish 1.1?

@vlazar
Copy link
Collaborator

vlazar commented Mar 16, 2016

Sure, the 1.1 is ready, unless you want to name it 2.0 to satisfy expectations like #16873

I'm not sure if it's possible to publish 1.0 now. You can try to unpublish, then checkout v1.0.0 tag, fix version in package.json and try publish again.

But according to https://docs.npmjs.com/cli/unpublish

Even if a package version is unpublished, that specific name and version combination can never be reused. In order to publish the package again, a new version number must be used.

Maybe it's for same author only, since you only published 0.0.0, you can try to publish 1.0.0

@vlazar
Copy link
Collaborator

vlazar commented Mar 16, 2016

One more thought, npm badge!

@LeaVerou
Copy link
Owner

Eh, whatever. Since we have a new version, it doesn't matter anymore.
v1.1 published!

@emmenko
Copy link

emmenko commented Mar 17, 2016

Wow, that was quick :)

Thanks for start using semver!

@emmenko
Copy link

emmenko commented Mar 17, 2016

Btw: if you use commitizen with the conventional changelog you get changelogs generated for free.

@ramauf
Copy link

ramauf commented Mar 21, 2016

q

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants