-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partial revert of PackageReference #191
Merged
rjmurillo
merged 2 commits into
LeCantaloop:support/10.0.x
from
rjmurillo:hotfix/10.0.1
Feb 12, 2018
Merged
Partial revert of PackageReference #191
rjmurillo
merged 2 commits into
LeCantaloop:support/10.0.x
from
rjmurillo:hotfix/10.0.1
Feb 12, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
Due to bug NuGet/Home#5979, when creating a NuGet packages, the dependencies are not populated in the generated nupkg file based on PackageReference in csproj (but are if packages.config is present). Since this only impacts projects for redistribution via NuGet, those projects have their PackageReference changes reverted to packages.config
6fceab2
to
44e6dbd
Compare
❌ Build Qwiq 440 failed (commit 1d0b912f16 by @rjmurillo) |
1 similar comment
❌ Build Qwiq 440 failed (commit 1d0b912f16 by @rjmurillo) |
❌ Build Qwiq 443 failed (commit 1d0b912f16 by @rjmurillo) |
1 similar comment
❌ Build Qwiq 443 failed (commit 1d0b912f16 by @rjmurillo) |
Humanizer is used to "humanize" some test output messages
1 similar comment
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to bug NuGet/Home#5979, when creating a NuGet packages, the dependencies are not populated in the generated nupkg file based on PackageReference in csproj (but are if packages.config is present). Since this only impacts projects for redistribution via NuGet, those projects have their PackageReference changes reverted to packages.config