Add completion for dismissing view controller

[amir-inmanage]

Expected behavior

completion for dismissing view controller

Actual behavior

no completion for dismissing view controller

Steps to reproduce the behavior

[LcTwisk]

Can you be more specific about what the issue exactly is?

[amir-inmanage]

I dont know when the user closing (dissmising) the imageviewercontrolller (pressing X button), you should foward the action with a custom delegate or any protocol.

…

On Thu, Oct 26, 2017 at 3:37 PM, Lucas ***@***.***> wrote: Can you be more specific about what the issue exactly is? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#9 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AJVB9e10zvgWzBz5QP1UMSWna2jookYoks5swH0mgaJpZM4QHUIS> .

-- Amir Ben-Salomon | IOS Developer Phone: +972-54-7430492 <+972%2054-311-7217> Address: 3 Hashfela St. Tel-Aviv IL, 66183 Israel

[amir-inmanage]

great work btw!

…

On Thu, Oct 26, 2017 at 3:41 PM, amir bensalomon ***@***.***> wrote: I dont know when the user closing (dissmising) the imageviewercontrolller (pressing X button), you should foward the action with a custom delegate or any protocol. On Thu, Oct 26, 2017 at 3:37 PM, Lucas ***@***.***> wrote: > Can you be more specific about what the issue exactly is? > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#9 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AJVB9e10zvgWzBz5QP1UMSWna2jookYoks5swH0mgaJpZM4QHUIS> > . > -- Amir Ben-Salomon | IOS Developer Phone: +972-54-7430492 <+972%2054-311-7217> Address: 3 Hashfela St. Tel-Aviv IL, 66183 Israel

-- Amir Ben-Salomon | IOS Developer Phone: +972-54-7430492 <+972%2054-311-7217> Address: 3 Hashfela St. Tel-Aviv IL, 66183 Israel

[LcTwisk]

Thanks! Great to hear that you like it.
I think it would be very nice to have such a delegate protocol. Are there any other event you can think of that should also be added to this protocol? (next to dismissal of the VC)