Unified Download Progress for Huggingface and Modelscope #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wzh1994
reviewed
Dec 18, 2024
wzh1994
reviewed
Dec 18, 2024
wzh1994
reviewed
Dec 18, 2024
wzh1994
reviewed
Dec 19, 2024
|
|
||
| def __init__(self, call_back=None, token=None): | ||
| self._token = token if self._verify_hub_token(token) else None | ||
| self._call_back = call_back |
There was a problem hiding this comment.
callback不放到self，而是在def download(self, model_id, model_dir)中传入，并通过参数传给_polling_progress
| return model_save_dir if model_save_dir else model | ||
| def validate_token(self): | ||
| if self.model_source == 'huggingface': | ||
| return HuggingfaceDownloader(token=self.token).verify_hub_token() |
There was a problem hiding this comment.
HuggingfaceDownloader / ModelscopeDownloader 能不能在ModelManager创建的时候直接初始化，而不是每次调用函数时候初始化一个新的
wzh1994
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
News：
tqdmis abolished: Unified download progress for huggingface and modelscope #390validate_tokenvalidate_model_idVerify Multi-thread: