Rag/improve file manage #393
Open
+238
−95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperEver
force-pushed
the
rag/improve_file_manage
branch
from
3bca1fe to
7bdeed6
Compare
wzh1994
reviewed
Dec 17, 2024
| @@ -238,7 +304,7 @@ def list_kb_group_files(self, group: str = None, limit: Optional[int] = None, de | |||
| upload_status: Union[str, List[str]] = DocListManager.Status.all, | |||
| exclude_upload_status: Optional[Union[str, List[str]]] = None): | |||
| query = """ | |||
| SELECT documents.doc_id, documents.path, documents.status, documents.metadata, | |||
| SELECT documents.doc_id, documents.path, documents.status, documents.meta, | |||
There was a problem hiding this comment.
sqlalchemy 的保留关键字，不能用metadata
lazyllm/tools/rag/utils.py
Outdated
| def get_safe_delete_files(self): | ||
| ids = [] | ||
| with self._db_lock, self._engine.connect() as conn: | ||
| stmt = select(KBDocument.doc_id).where(KBDocument.status.in_(["success", "failed"])) |
There was a problem hiding this comment.
这里是不是也一次性把waiting的状态更新为failed，然后返回出来
added 6 commits
December 19, 2024 13:53
thread 2. add delete_obsolete_files in doclistmaager, it will find status==delting and reference_count==0 file to delete 3. Add reference_count, when adding to kbgroup document reference_count will be updated to +1, when deleting from kbgroup it will be updated to -1 4. Add KBOperationLogs, currently only deleting file operation will be recoreder 5. Modifiy worker thread. when group is default, it will check to delete obsolete file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.