support windows #356
Merged
support windows #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wzh1994
reviewed
Nov 22, 2024
lazyllm/tools/rag/rerank.py
Outdated
| def __new__(cls, name: str = "ModuleReranker", *args, **kwargs): | ||
| assert name in cls.registered_reranker, f"Reranker: {name} is not registered, please register first." | ||
| item = cls.registered_reranker[name] | ||
| def __new__(cls, name: Optional[Union[Callable, str]] = "ModuleReranker", *args, **kwargs): |
There was a problem hiding this comment.
这个Callable是给到model参数，不是给到name参数
There was a problem hiding this comment.
Reranker(name='ModuleReranker', model=TrainableModule(xxx))
added 2 commits
November 22, 2024 17:27
wzh1994
reviewed
Nov 22, 2024
lazyllm/tools/rag/rerank.py
Outdated
| assert name in cls.registered_reranker, f"Reranker: {name} is not registered, please register first." | ||
| item = cls.registered_reranker[name] | ||
| else: | ||
| item = cls.registered_reranker["ModuleReranker"] |
lazyllm/tools/rag/rerank.py
Outdated
| output_format: Optional[str] = None, join: Union[bool, str] = False, **kwargs) -> None: | ||
| super().__init__() | ||
| self._name = name | ||
| self._name = name if isinstance(name, str) else "ModuleReranker" |
dorren002
force-pushed
the
winsupport
branch
from
5e4aa0a to
9063580
Compare
dorren002
force-pushed
the
winsupport
branch
from
9063580 to
93139ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.