Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfixes: variable assignments fix and milvus throws an error when text similarity is used #339

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

ouonline
Copy link
Contributor

@ouonline ouonline commented Nov 11, 2024

  1. wrong parameter names that are ignored by index.query()
  2. set default query mode to 'embedding' if similarity is None
  3. milvus does not support text queries
  4. nodes should be created before store.query() is called when type is None or default
  5. using add() instead of update() to insert single element into a set
  6. set embed_keys so that it is assign to self._embed_keys properly in Retriever::__init__()

@wzh1994 wzh1994 merged commit 940b944 into LazyAGI:main Nov 12, 2024
10 of 11 checks passed
@ouonline ouonline changed the title index various bugfixes bugfixes: variable assignments fix and milvus throws an error when text similarity is used Nov 12, 2024
@ouonline ouonline deleted the index-bugfix branch November 19, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants