Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR] Separator/Spacer #57

Closed
electronicm opened this issue Sep 10, 2021 · 4 comments
Closed

[FR] Separator/Spacer #57

electronicm opened this issue Sep 10, 2021 · 4 comments
Labels
Done Should be fixed in next released - will be tested when released enhancement New feature or request

Comments

@electronicm
Copy link

It would increase clarity if you could place separators between icons.
Not so Importent: It would be even more ingenious if you could bind these separators to the status "Only show while printer is printing", "Hide when not operational", "Only show while icons left/right are displayed".

Example idle:
CPUTemp CPULoad

Example heating bed:
Bed | CPUTemp CPULoad

Example printing:
Layer %Completed | Bed Tool0 | CPUTemp CPULoad
@electronicm electronicm changed the title [FR] Spacer [FR] Separator/Spacer Sep 10, 2021
@LazeMSS LazeMSS added the enhancement New feature or request label Sep 11, 2021
@LazeMSS
Copy link
Owner

LazeMSS commented Sep 11, 2021

Working on it.

LazeMSS added a commit that referenced this issue Sep 20, 2021
@LazeMSS
Added option to have seperators (#57)
f30c50a
@LazeMSS LazeMSS added the Done Should be fixed in next released - will be tested when released label Sep 20, 2021
@LazeMSS LazeMSS mentioned this issue Sep 20, 2021
Merged
@LazeMSS
Copy link
Owner

LazeMSS commented Sep 20, 2021

Included in: https://github.com/LazeMSS/OctoPrint-TopTemp/releases/tag/0.0.1.6

@LazeMSS LazeMSS closed this as completed Sep 20, 2021
@electronicm
Copy link
Author

This works also like a charm.
Is there still a possibility that you add the option "Show separator on left" or a DropDown with "none, left, right, both"?

@LazeMSS
Copy link
Owner

LazeMSS commented Sep 27, 2021

Just to understand - why do you want the seperator on the left etc. I understand the grouping of items but why left, none etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Done Should be fixed in next released - will be tested when released enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@electronicm @LazeMSS