Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: require avs register metadata in allocation manager #1025

Open
wants to merge 7 commits into
base: slashing-magnitudes-fixes
Choose a base branch
from
Open

feat: require avs register metadata in allocation manager #1025

wants to merge 7 commits into from
+44 −1

Conversation

bowenli86
Copy link
Member

@bowenli86 bowenli86 commented Jan 14, 2025 •
edited
Loading

require avs register metadata in allocation manager before they can create operatorset

@bowenli86 bowenli86 changed the title feat: enforce adn track AVS to register metadata feat: enforce and track AVS to register metadata Jan 14, 2025
ypatil12
ypatil12 requested changes Jan 14, 2025
View reviewed changes
src/contracts/core/AllocationManager.sol Outdated Show resolved Hide resolved
src/contracts/core/AllocationManager.sol Outdated Show resolved Hide resolved
ypatil12
ypatil12 requested changes Jan 23, 2025
View reviewed changes
src/contracts/core/AVSDirectoryStorage.sol Outdated Show resolved Hide resolved
src/contracts/core/AllocationManagerStorage.sol Outdated Show resolved Hide resolved
@bowenli86 bowenli86 changed the title feat: enforce and track AVS to register metadata feat: require avs register metadata in allocation manager Feb 5, 2025
@bowenli86
Copy link
Member Author

bowenli86 commented Feb 7, 2025 •
edited
Loading

chatted with Scott and got a greenlight

@ypatil12 @8sunyuan i'm changing the assertion from when register operator to when create operator set so it can gate the workflow even eariler and more uptream

@bowenli86
Copy link
Member Author

@gpsanant @stevennevins fyi, we will merge this in soon

@ypatil12 ypatil12 added the enhancement New feature or request label Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@8sunyuan 8sunyuan Awaiting requested review from 8sunyuan

@ypatil12 ypatil12 Awaiting requested review from ypatil12

@stevennevins stevennevins Awaiting requested review from stevennevins

@gpsanant gpsanant Awaiting requested review from gpsanant

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bowenli86 @8sunyuan @ypatil12