Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate pprof to encoder and node #935

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Integrate pprof to encoder and node #935

merged 3 commits into from
Nov 26, 2024

Conversation

jianoaix
Copy link
Contributor

@jianoaix jianoaix commented Nov 26, 2024 •
edited
Loading

Why are these changes needed?

The Encoder and Node are two key data plane components which we'd want to understand performance more deeply.

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@jianoaix jianoaix changed the title Integratepprof Integrate pprof to encoder and node Nov 26, 2024
@jianoaix jianoaix requested review from bxue-l2 and dmanc November 26, 2024 18:28
@jianoaix jianoaix merged commit b3a90d1 into Layr-Labs:master Nov 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmanc dmanc dmanc approved these changes

@bxue-l2 bxue-l2 Awaiting requested review from bxue-l2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jianoaix @dmanc