Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PadToPowerOf2 function #877

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Conversation

dmanc
Copy link
Contributor

@dmanc dmanc commented Nov 8, 2024

Why are these changes needed?

Blob does not need to be padded to a power of 2, just need to ensure the chunk length is a power of 2.

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@dmanc dmanc requested a review from mooselumph November 8, 2024 22:30
@dmanc dmanc merged commit 9aeea05 into Layr-Labs:master Nov 8, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants