Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Attestation Interface & Metadata Store #868

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

ian-shim
Copy link
Contributor

@ian-shim ian-shim commented Nov 6, 2024

Why are these changes needed?

  • updates attestation interface for v2
  • implements metadata store methods related to batch header & attestation

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@ian-shim ian-shim marked this pull request as ready for review November 6, 2024 23:58
// Relevant quorum numbers for the attestation
repeated uint32 quorum_numbers = 5;
// Block number that the operator state is based on for the attestation
uint64 reference_block_number = 6;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the reference_block_number needed here since the consumer of this would need the BatchHeader anyway?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

Copy link
Collaborator

@mooselumph mooselumph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ian-shim ian-shim merged commit 827e656 into Layr-Labs:master Nov 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants