New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docker build args and restore semver info on operator node #857

Merged

pschork merged 2 commits into master from pschork/fix_docker_args

Nov 1, 2024

Contributor

pschork commented Nov 1, 2024

The build args need to be defined in the builder context

> BUILD_TAG=0.8.5 SEMVER=0.8.5 GITDATE=1730418012 GIT_SHA=f3cec0c9fed730c1d852420bbf57a3852ff583ef GIT_SHORT_SHA=f3cec0c docker buildx bake node

> docker run ghcr.io/layr-labs/eigenda/node:0.8.5 --version
2024/11/01 01:32:10 maxprocs: Leaving GOMAXPROCS=8: CPU quota undefined
da-node version 0.8.5-f3cec0c-1730418012

I've made sure the lint is passing in this PR.
I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
I've checked the new test coverage and the coverage percentage didn't drop.
Testing Strategy
- Unit tests
- Integration tests
- This PR is not tested :(


          Fix docker build args and restore semver info on operator node

0f30fc3

The build args need to be defined in the builder context

pschork requested review from samlaf, ian-shim, dmanc and bxue-l2

November 1, 2024 01:33

samlaf approved these changes

View reviewed changes

Contributor

samlaf left a comment

Nice find! Described here: https://docs.docker.com/build/building/variables/#scoping


          Lint

262d89e

pschork merged commit b649871 into master

9 checks passed

pschork deleted the pschork/fix_docker_args branch

November 5, 2024 07:47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet