Unexport payment signer #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-shim
force-pushed
the
unexport-payment-signer
branch
2 times, most recently
from
e9c4fc3 to
fa1c8ef
Compare
ian-shim
force-pushed
the
unexport-payment-signer
branch
from
fa1c8ef to
b90736d
Compare
ian-shim
requested review from
ad-eigen and
anupsv
and removed request for
ad-eigen
anupsv
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Directly instantiating
PaymentSignerwithoutPrivateKeywill panic when methods are called.This PR unexports
auth.PaymentSignerso that it has to be instantiated with the constructor.Checks