Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate chunks in retrieval client #82

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Validate chunks in retrieval client #82

merged 1 commit into from
Dec 5, 2023

Conversation

ian-shim
Copy link
Contributor

@ian-shim ian-shim commented Nov 28, 2023 •
edited
Loading

Why are these changes needed?

Previously, retrieval client only validated the blob header retrieved from DA nodes against the batch root.
It now validates the chunks retrieved from the DA nodes as well.

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@ian-shim ian-shim marked this pull request as ready for review November 28, 2023 17:58
teddyknox pushed a commit that referenced this pull request Nov 29, 2023
@bxue-l2
Telemetry (#82)
199b389
@ian-shim ian-shim merged commit 064f756 into Layr-Labs:master Dec 5, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianoaix jianoaix jianoaix approved these changes

@mooselumph mooselumph mooselumph approved these changes

@antojoseph antojoseph Awaiting requested review from antojoseph

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ian-shim @mooselumph @jianoaix