Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ExpresseionValues -> ExpressionValues typo #796

Merged
merged 1 commit into from
Oct 9, 2024
Merged

fix: ExpresseionValues -> ExpressionValues typo #796

merged 1 commit into from
Oct 9, 2024

Conversation

hopeyen
Copy link
Contributor

@hopeyen hopeyen commented Oct 8, 2024

Why are these changes needed?

simply updating a typoo_O

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@hopeyen hopeyen requested a review from ian-shim October 8, 2024 23:59
ian-shim
ian-shim approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@ian-shim ian-shim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇

@hopeyen hopeyen merged commit 6c954fc into master Oct 9, 2024
10 checks passed
@hopeyen hopeyen deleted the hope/expression-typo branch October 9, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ian-shim ian-shim ian-shim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hopeyen @ian-shim